Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for performance #1817

Closed
wants to merge 8 commits into from
Closed

Refactor for performance #1817

wants to merge 8 commits into from

Conversation

hgrecco
Copy link
Owner

@hgrecco hgrecco commented Jul 15, 2023

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #1817 will degrade performances by 23.33%

Comparing develop (295e39c) with master (2d649ea)

Summary

🔥 28 improvements
❌ 4 (👁 1) regressions
✅ 389 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master develop Change
🔥 test_build_cache 7.4 ms 3.3 ms ×2.3
🔥 test_getattr[True-ms] 1,109 µs 152.2 µs ×7.3
🔥 test_getattr[False-kilometer] 1,146.2 µs 881.6 µs +30.02%
🔥 test_getattr[False-millisecond] 1,143.7 µs 887.9 µs +28.81%
🔥 test_getitem[True-ms] 2.5 ms 1.9 ms +32.25%
🔥 test_parse_unit_name[True-meter] 360.9 µs 59.1 µs ×6.1
🔥 test_parse_unit_name[True-kilometer] 384.7 µs 57.1 µs ×6.7
🔥 test_parse_unit_name[True-second] 341.3 µs 57.7 µs ×5.9
🔥 test_parse_unit_name[True-minute] 360.2 µs 57.7 µs ×6.2
🔥 test_parse_unit_name[True-angstrom] 360.3 µs 57.9 µs ×6.2
🔥 test_parse_unit_name[True-millisecond] 384 µs 56.9 µs ×6.7
🔥 test_parse_unit_name[True-ms] 381.7 µs 57.2 µs ×6.7
🔥 test_parse_unit_name[False-meter] 365.8 µs 57.8 µs ×6.3
🔥 test_parse_unit_name[False-second] 347.3 µs 57.6 µs ×6
🔥 test_parse_unit_name[False-minute] 366.1 µs 57.7 µs ×6.3
🔥 test_parse_unit_name[False-angstrom] 366 µs 57.8 µs ×6.3
🔥 test_parse_units[True-ms] 1,055.4 µs 91.7 µs ×12
🔥 test_parse_units[False-kilometer] 1,090.4 µs 842.4 µs +29.45%
🔥 test_parse_units[False-millisecond] 1,076.9 µs 847.2 µs +27.11%
🔥 test_parse_expression[True-ms] 2.6 ms 2 ms +31.83%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@hgrecco hgrecco force-pushed the develop branch 4 times, most recently from 39f2117 to 00187e9 Compare July 15, 2023 19:13
@hgrecco hgrecco force-pushed the develop branch 2 times, most recently from 7481ec0 to e5641de Compare July 16, 2023 20:53
@hgrecco
Copy functools.cache into pint for further modification
1e157bf 
This will be required to have instance specific and stackable cache
@hgrecco hgrecco changed the title Add cache to parse_unit_name Refactor for performance Jul 16, 2023
@hgrecco hgrecco closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgrecco